Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct SLURM wrong import #10842

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Correct SLURM wrong import #10842

merged 2 commits into from
Dec 1, 2021

Conversation

mbortolon97
Copy link
Contributor

What does this PR do?

Correct SLURM plugin wrong import in the documentation about using pytorch-lightning with SLURM

Breaking changes

None

Before submitting

  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@mbortolon97
Correct SLURM wrong import
63dafa2 
Correct SLURM plugin wrong import in the documentation about using pytorch-lightning with SLURM
@awaelchli awaelchli added the docs Documentation related label Nov 30, 2021
@awaelchli awaelchli added this to the 1.6 milestone Nov 30, 2021
@mergify mergify bot added the ready PRs ready to be merged label Nov 30, 2021
@rohitgr7 rohitgr7 enabled auto-merge (squash) November 30, 2021 14:56
@carmocca
Copy link
Contributor

carmocca commented Nov 30, 2021 •
edited
Loading

@mbortolon97 Can you rebase master and push again?

@rohitgr7 rohitgr7 merged commit f7c15f2 into Lightning-AI:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@justusschock justusschock justusschock approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub ananthsub approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees
No one assigned
Labels
docs Documentation related environment: slurm ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
7 participants
@mbortolon97 @carmocca @ananthsub @awaelchli @Borda @justusschock @rohitgr7